fixing issues with a HEREDOC entry in git.status #385
Conversation
* fixing status#pretty using <<~ because we only maintain on Ruby 2.3+ now * fixing a rake warning about branch not using a decomposed argument Signed-off-by: Vern Burton <me@vernburton.com>
Signed-off-by: Vern Burton <me@vernburton.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There was a problem hiding this comment.
At first I was concerned that dropping older versions of Ruby should require a MAJOR version bump. After some reading, I think it is something to consider, but might not be necessary.
Here is the discussion I found helpful:
https://www.reddit.com/r/ruby/comments/7vtceq/when_is_it_okay_to_drop_support_for_ruby_versions/
|
@jcouball - I don't have an argument either way, I would be fine with a MINOR. The change in the gemspec should prevent |
|
Let's let this PR go with just a patch version bump. By semver definition, that is all that is needed. |
|
any status on this? |
Your checklist for this pull request
馃毃Please review the guidelines for contributing to this repository.
Description
fix #384
Removes `#strip_heredoc
This change breaks Ruby 2.2 or less and the
<<~only exists in Ruby 2.3+. We are only testing Ruby 2.3 and later in Travis CI and I would argue that we should only be supporting those in the newer versions of the gem.Fixing branch for a message being used interpreted as an arg list and not as a decomposed argument