Update test of 'git worktree add' with no commits #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Couball <jcouball@yahoo.com>
git-2.42.0 changes the behavior of `git worktree add` when there are no commits in the repository. Prior to 2.42.0, an error would result with creating a new worktree. Starting wtih 2.42.0, git will create a new, orphaned branch for the worktree. Signed-off-by: James Couball <jcouball@yahoo.com>
jcouball
force-pushed
the
fix_worktree_test
branch
2 times, most recently
from
67ca08a
to
f19d207
Compare
Signed-off-by: James Couball <jcouball@yahoo.com>
jcouball
force-pushed
the
fix_worktree_test
branch
from
f19d207
to
b0b8ffd
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
git-2.42.0 changes the behavior of
git worktree addwhen there are no commits in the repository. Prior to 2.42.0, an error would result with creating a new worktree. Starting wtih 2.42.0, git will create an orphan branch for the worktree.Other Changes
This PR also adds
Git::Lib#compare_version_to(other_version)which return -1 if the git command version is less than the other_version, 0 if equal, and 1 if greater than.This PR rewrites tests/units/test_repack.rb to make sure that the correct git command was called without error when Git::Lib#repack is called. Prior to this change, the test actually checked to see if the size of the repository was less after calling repack which was not always the case in the tests.