Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly name remote tracking branch in test #676

Merged
merged 1 commit into from
Nov 19, 2023
Merged

Conversation

jcouball
Copy link
Member

Your checklist for this pull request

馃毃Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

TestRemotes#test_push fails depending on the git configuration push.default if an explicit remote branch name is not given. In particular, values of upstream or tracking values would make the test fail.

In order not to depend on this setting, explicitly name the remote branch to push to. This is not relevant to the test.

Signed-off-by: James Couball <jcouball@yahoo.com>
@jcouball jcouball merged commit 0bb965d into master Nov 19, 2023
9 checks passed
@jcouball jcouball deleted the explicit_branch branch November 19, 2023 23:20
@jcouball jcouball mentioned this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant