:unless condition with Hash: wrong implementation and specs

[marshall-lee]

:if it can be used with hash like if: { cond1: 'foo', cond2: false }. It means that this exposure should be exposed iff all the conditions are matching. It means that it should not be exposed with options like:

• cond1: 'bar', cond2: false
• cond1: 'foo', cond2: true
• cond1: 'foo'
• cond2: false .

The only valid options value when it's exposable is cond1: 'foo', cond: false.

Documentation says that :unless is an opposite of :if. So the exposure should be exposable iff any of the conditions is not matching.

And i also found a spec that tells the same idea in its text: only passes through hash :unless exposure if any attributes do not match:

it 'only passes through hash :unless exposure if any attributes do not match' do
  exposure_options = { unless: { condition1: true, condition2: true } }

  # right
  expect(subject.send(:conditions_met?, exposure_options, {})).to be true
  # wrong
  expect(subject.send(:conditions_met?, exposure_options, condition1: true)).to be false
  # right
  expect(subject.send(:conditions_met?, exposure_options, condition1: true, condition2: true)).to be false
  # wrong
  expect(subject.send(:conditions_met?, exposure_options, condition1: false, condition2: true)).to be false
  # right
  expect(subject.send(:conditions_met?, exposure_options, condition1: true, condition2: true, other: true)).to be false
  # right
  expect(subject.send(:conditions_met?, exposure_options, condition1: false, condition2: false)).to be true
end

If you look carefully you'll see It's wrong:

• expectation with options condition1: true should be true, because it doesn't contain matching condition2 element.
• expectation with options condition1: false, condition2: true should be true because condition1 doesn't match.

[marshall-lee]

I'd open a PR later.