Fix nil values causing errors when merge option passed #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arempe93
force-pushed
the
fix-nil-merge
branch
from
2def450
to
01bdb33
Compare
|
thanks @arempe93 … please can you make danger happy (copy it over) |
|
sorry - could you explain what copy it over is? i thought I had fixed the danger problem with the changelog |
|
all fine now … 👍 |
LeFnord
approved these changes
Nov 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if something is exposed with
merge: trueand the value ends up beingnil, it raises an unhandled exception. This changes that behavior to add nothing to the output and throw no exception