Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call procs in context of entity instance #43

Merged
merged 5 commits into from
Jan 7, 2014

Conversation

joelvh
Copy link
Contributor

@joelvh joelvh commented Jan 4, 2014

This allows accessing other information about the entity instance from procs. Technically makes the "object" argument when defining exposure options redundant.

@dblock
Copy link
Member

dblock commented Jan 4, 2014

I like it. It needs tests and a CHANGELOG entry.

@joelvh
Copy link
Contributor Author

joelvh commented Jan 7, 2014

@dblock added tests and CHANGELOG update

@@ -1,7 +1,7 @@
Next Release
============
* Ruby 1.8.x is no longer supported - [@dblock](https://github.com/dblock).
* [#36](https://github.com/intridea/grape-entity/pull/35): Enforcing Ruby style guidelines via Rubocop - [@dblock](https://github.com/dblock).
* [#36](https://github.com/intridea/grape-entity/pull/36): Enforcing Ruby style guidelines via Rubocop - [@dblock](https://github.com/dblock).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem :-)

dblock added a commit that referenced this pull request Jan 7, 2014
Call procs in context of entity instance
@dblock dblock merged commit 61e5cf9 into ruby-grape:master Jan 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants