Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMethodError on partials when upgrading to rabl 0.11.2 and above #31

Closed
ronenm opened this issue Nov 22, 2014 · 13 comments
Closed

NoMethodError on partials when upgrading to rabl 0.11.2 and above #31

ronenm opened this issue Nov 22, 2014 · 13 comments
Labels

Comments

@ronenm
Copy link

ronenm commented Nov 22, 2014

Hi,

I'm using the following (and other) partial in my rabl views for grape:

  node :images do |partner|
      partial("images", :object => partner.gallery.attachments)
 end

When upgrading to the latest rabl (0.11.4) I noticed that I'm starting to get the following error message:

NoMethodError (undefined method views' for #<Grape::Util::HashStack:0x007ffb4d9d08a0>): app/views/api/partner.rabl:7:inblock in eval_source'

Going backward I saw that this error message started to appear at rabl 0.11.2 (it works fine in 0.11.1).

Thanks,
Ronen

@dblock dblock added the bug? label Nov 24, 2014
@dblock
Copy link
Member

dblock commented Nov 24, 2014

Looks like a legit problem. Maybe you can PR an update to rabl in this project that reproduces the problem, to start?

@ronenm
Copy link
Author

ronenm commented Nov 24, 2014

Sure. I'll prepare a spec for this case if the current specs do not catch
the issue. Probably will be ready on Friday.

On Mon, Nov 24, 2014 at 3:28 PM, Daniel Doubrovkine (dB.) @dblockdotorg <
notifications@github.com> wrote:

Looks like a legit problem. Maybe you can PR an update to rabl in this
project that reproduces the problem, to start?


Reply to this email directly or view it on GitHub
#31 (comment).

רונן מולדובן

מנחה סדנאות, מטפל בתטא-הילינג, מאמן אישי ועסקי מייסד ומנהל בית גשרים
נייד 054-4818159
טלפון 04-6620199
פקס 153-4-6620199
אימייל ronen@beit-gsharim.com
www.beit-gsharim.com
http://www.beit-gsharim.com
צ'ט Skype: ronen.moldovan MSN: moldovan@hotmail.com
צרו עימי קשר [image: Linkedin]
http://www.linkedin.com/profile?viewProfile=&key=399337&locale=en_US&trk=tab_pro[image:
Facebook] http://www.facebook.com/#%21/ronen.moldovan[image: Twitter]
https://twitter.com/gsharim

--- @ WiseStamp Signature
http://my.wisestamp.com/link?u=4mmzgsymmkn8mh7d&site=www.wisestamp.com/email-install.
Get it now
http://my.wisestamp.com/link?u=4mmzgsymmkn8mh7d&site=www.wisestamp.com/email-install

@phallstrom
Copy link

Same error. Reverting to 0.11.1 resolves it.

@LTe
Copy link
Member

LTe commented Dec 5, 2014

@phallstrom @ronenm do you use grape-rabl and sinatra in the same time?

Related: nesquena/rabl#597

@phallstrom
Copy link

@LTe Yes to grape-rabl, No to sinatra.

@ronenm
Copy link
Author

ronenm commented Dec 5, 2014

No not using it with Sinatra.
בתאריך 5 בדצמ 2014 18:14, ‏"Philip Hallstrom" notifications@github.com
כתב:

@LTe https://github.com/LTe Yes to grape-rabl, No to sinatra.


Reply to this email directly or view it on GitHub
#31 (comment).

@LTe
Copy link
Member

LTe commented Dec 5, 2014

@ronenm @phallstrom @dblock I created pull request to rabl. This should fix problem.

Related: nesquena/rabl#602

@ronenm
Copy link
Author

ronenm commented Dec 5, 2014

@LTe, I fetched your pull request to a local path and can confirm that the issue has been solved with it.

Waiting for the release of rabl that will include this fix.

Many thanks for the help.

@DouweM
Copy link

DouweM commented Dec 5, 2014

The PR has been merged into rabl! A new release will be issued soon.

@dblock
Copy link
Member

dblock commented Dec 6, 2014

Are we saying this can be closed once that is released?

@LTe
Copy link
Member

LTe commented Dec 6, 2014

@dblock already released nesquena/rabl@34cd122

Do you think that we should bump dependency for rabl to >= 0.11.5?

@ronenm
Copy link
Author

ronenm commented Dec 6, 2014

Sure. I will close once I check it with the official release.

On Sat, Dec 6, 2014 at 2:02 AM, Daniel Doubrovkine (dB.) @dblockdotorg <
notifications@github.com> wrote:

Are we saying this can be closed once that is released?


Reply to this email directly or view it on GitHub
#31 (comment).

רונן מולדובן

מנחה סדנאות, מטפל בתטא-הילינג, מאמן אישי ועסקי מייסד ומנהל בית גשרים
נייד 054-4818159
טלפון 04-6620199
פקס 153-4-6620199
אימייל ronen@beit-gsharim.com
www.beit-gsharim.com
http://www.beit-gsharim.com
צ'ט Skype: ronen.moldovan MSN: moldovan@hotmail.com
צרו עימי קשר [image: Linkedin]
http://www.linkedin.com/profile?viewProfile=&key=399337&locale=en_US&trk=tab_pro[image:
Facebook] http://www.facebook.com/#%21/ronen.moldovan[image: Twitter]
https://twitter.com/gsharim

--- @ WiseStamp Signature
http://my.wisestamp.com/link?u=4mmzgsymmkn8mh7d&site=www.wisestamp.com/email-install.
Get it now
http://my.wisestamp.com/link?u=4mmzgsymmkn8mh7d&site=www.wisestamp.com/email-install

@ronenm
Copy link
Author

ronenm commented Dec 6, 2014

Everything's working fine with Rabl 0.11.5

@ronenm ronenm closed this as completed Dec 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants