-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change grape dependency to support new versions #20
Conversation
@@ -15,3 +15,4 @@ spec/reports | |||
test/tmp | |||
test/version_tmp | |||
tmp | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's .idea
? This should probably not be part of this commit, it's not relevant.
Add a Make these changes via |
One more thing, the README tells you to use a specific version of things, would you mind fixing that, too? Appreciate it. |
I think it's better to change vesion in README too, agree? |
I mean we say |
Added all changes |
@@ -1,3 +1,7 @@ | |||
#### Next Release | |||
|
|||
* Relaxed dependency on a specific version of Grape |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please put this in the same format as all the other changes below? Thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, did this. And omitted commit link, seems it doesn't make sense until pull request not merged.
@@ -1,3 +1,7 @@ | |||
#### Next Release | |||
|
|||
* Relaxed dependency on a specific version of Grape [#20](https://github.com/LTe/grape-rabl/pull/11) [@cheef](https://github.com/cheef) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and this is correct url to my pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That link, /11 should say /20, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, not noticed
Merging, thanks for being patient with the nitpicking. |
Change grape dependency to support new versions
0.2.2 released |
New grape version working fine for me with this gem