Fix rubocop offences

ruby-grape · Jul 1, 2023 · 417ff32 · 417ff32
1 parent fc10f59
commit 417ff32
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 5000`
-# on 2023-05-27 20:47:15 UTC using RuboCop version 1.50.2.
+# on 2023-07-01 15:43:53 UTC using RuboCop version 1.50.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -100,6 +100,12 @@ Lint/MissingSuper:
     - 'lib/grape/router/pattern.rb'
     - 'lib/grape/validations/validators/base.rb'
 
+# Offense count: 1
+# Configuration parameters: CountComments, Max, CountAsOne, AllowedMethods, AllowedPatterns.
+Metrics/MethodLength:
+  Exclude:
+    - 'lib/grape/endpoint.rb'
+
 # Offense count: 2
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
 # SupportedStylesForLeadingUnderscores: disallowed, required, optional
@@ -134,7 +140,7 @@ RSpec/AnyInstance:
     - 'spec/grape/api_spec.rb'
     - 'spec/grape/middleware/base_spec.rb'
 
-# Offense count: 342
+# Offense count: 343
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -324,7 +330,7 @@ RSpec/MessageChain:
   Exclude:
     - 'spec/grape/middleware/formatter_spec.rb'
 
-# Offense count: 136
+# Offense count: 147
 # Configuration parameters: .
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
@@ -335,7 +341,7 @@ RSpec/MissingExampleGroupArgument:
   Exclude:
     - 'spec/grape/middleware/exception_spec.rb'
 
-# Offense count: 765
+# Offense count: 772
 # Configuration parameters: Max.
 RSpec/MultipleExpectations:
   Exclude:
@@ -413,7 +419,7 @@ RSpec/MultipleMemoizedHelpers:
     - 'spec/grape/request_spec.rb'
     - 'spec/grape/validations/attributes_doc_spec.rb'
 
-# Offense count: 2137
+# Offense count: 2150
 # Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
 # SupportedStyles: always, named_only
 RSpec/NamedSubject:
@@ -478,7 +484,7 @@ RSpec/NamedSubject:
     - 'spec/grape/validations/validators/presence_spec.rb'
     - 'spec/grape/validations_spec.rb'
 
-# Offense count: 174
+# Offense count: 173
 # Configuration parameters: Max, AllowedGroups.
 RSpec/NestedGroups:
   Exclude:
@@ -527,11 +533,10 @@ RSpec/RepeatedDescription:
     - 'spec/grape/validations/validators/allow_blank_spec.rb'
     - 'spec/grape/validations/validators/values_spec.rb'
 
-# Offense count: 10
+# Offense count: 8
 RSpec/RepeatedExample:
   Exclude:
     - 'spec/grape/api_spec.rb'
-    - 'spec/grape/dsl/request_response_spec.rb'
     - 'spec/grape/middleware/versioner/accept_version_header_spec.rb'
     - 'spec/grape/validations/validators/allow_blank_spec.rb'
 
@@ -559,7 +564,7 @@ RSpec/StubbedMock:
     - 'spec/grape/middleware/formatter_spec.rb'
     - 'spec/grape/parser_spec.rb'
 
-# Offense count: 114
+# Offense count: 122
 RSpec/SubjectStub:
   Exclude:
     - 'spec/grape/api_spec.rb'

diff --git a/lib/grape/endpoint.rb b/lib/grape/endpoint.rb
@@ -276,7 +276,6 @@ def run
       end
     end
 
-    # rubocop:disable Metrics/MethodLength
     def build_stack(helpers)
       stack = Grape::Middleware::Stack.new
 
@@ -317,7 +316,6 @@ def build_stack(helpers)
       builder.run ->(env) { env[Grape::Env::API_ENDPOINT].run }
       builder.to_app
     end
-    # rubocop:enable Metrics/MethodLength
 
     def build_helpers
       helpers = namespace_stackable(:helpers)