allow_blank boolean fix #1012
Merged
allow_blank boolean fix #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,7 +20,7 @@ | |||
| * [#942](https://github.com/intridea/grape/pull/942): Fixed forced presence for optional params when based on a reused entity that was also required in another context - [@croeck](https://github.com/croeck). | |||
| * [#1001](https://github.com/intridea/grape/pull/1001): Fixed calling endpoint with specified format with format in its path - [@hodak](https://github.com/hodak). | |||
| * [#1005](https://github.com/intridea/grape/pull/1005): Fixed the Grape::Middleware::Globals - [@urkle](https://github.com/urkle). | |||
|
|
|||
| * [#1012](https://github.com/intridea/grape/pull/1012): Fix allow_blank validator such that validation will not fail when a value of false is sent in a boolean param and allow_blank is set to false. - [@mfunaro](https://github.com/mfunaro). | |||
There was a problem hiding this comment.
There's "fix" instead of "fixed" and an extra period, make sure this looks like everything else. Maybe shorter?
[#1012](https://github.com/intridea/grape/pull/1012): Fixed `allow_blank: false` with a Boolean value of `false` - [@mfunaro](https://github.com/mfunaro).
|
Very good, see my comments above, squash the commits, too. Thanks. |
…alue of false is sent in a boolean param and allow_blank is set to false.
|
All set. Thanks for the feedback. Edit: Not sure what went wrong in the build. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix allow_blank validator such that validation will not fail when a value of false is sent in a boolean param and allow_blank is set to false.