Explicitly require ActiveSupport's Hash#except #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1087 |
|
I think there should be a CHANGELOG entry for this, please, via |
|
@dblock done |
|
I am going to be pedantic about this CHANGELOG, apologies :) This fixes running grape with ActiveSupport 3.x, right? Lets write this in the CHANGELOG as that fix? |
|
@dblock no need to apologize for pedantry :) |
This allows Grape to be run with ActiveSupport 3, without Rails. In ActiveSupport 4, this file ended up being required as a dependency of `active_support/core_ext/object/conversions`. Also, Rails itself includes this file.
|
@dblock updated again. Fingers crossed :) |
|
I like it, merging. |
dblock
added a commit
that referenced
this pull request
Aug 4, 2015
Explicitly require ActiveSupport's Hash#except
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows Grape to be run with ActiveSupport 3, without Rails.
In ActiveSupport 4, this file ended up being required as a
dependency of
active_support/core_ext/object/conversions. Also,Rails itself includes this file.