Don't fail even if invalid type value is provided #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,6 +14,7 @@ | |||
|
|
|||
| * [#1216](https://github.com/ruby-grape/grape/pull/1142): Fix JSON error response when calling `error!` with non-Strings - [@jrforrest](https://github.com/jrforrest). | |||
| * [#1225](https://github.com/ruby-grape/grape/pull/1225): Fix `given` with nested params not returning correct declared params - [@JanStevens](https://github.com/JanStevens). | |||
| * [#1249](https://github.com/ruby-grape/grape/pull/1249): Don't fail even if invalid type value is provided - [@namusyaka](https://github.com/namusyaka). | |||
|
|
|||
There was a problem hiding this comment.
We should specify the scope, it's only related to the params with default validator 
|
Force pushed. @dm1try How about this? |
| end | ||
| subject.post '/optional_hash_without_default_outer_params' do | ||
| { zone: params[:phone][:zone] } | ||
| end |
There was a problem hiding this comment.
I think we can remove this declarition and put the expectations to this context
it 'does not fail even if invalid params are provided' do
expect { post '/optional_hash_without_default', optional_hash_without_default: '5678' }.not_to raise_error
expect(last_response.status).to eq(400)
expect(last_response.body).to eq({ error: 'optional_hash_without_default is invalid' }.to_json)
endThere was a problem hiding this comment.
Wow, thanks!! Fixed.
|
@namusyaka looks good to me, |
dm1try
added a commit
that referenced
this pull request
Jan 19, 2016
Don't fail even if invalid type value is provided
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1245