Fix incorrect deprecations #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namusyaka
force-pushed
the
fix-incorrect-deprecations
branch
from
9877ddc
to
96eade9
Compare
| @@ -56,6 +57,15 @@ def route_path | |||
| pattern.path | |||
| end | |||
|
|
|||
| def hidden | |||
There was a problem hiding this comment.
Are we really just trying to make grape-swagger happy here? The whole hidden thing is not a Grape feature, just happens to be an option that grape-swagger "extends". Maybe it's better to expose options instead and let grape-swagger deal with it?
namusyaka
force-pushed
the
fix-incorrect-deprecations
branch
from
96eade9
to
9edb8f9
Compare
|
@dblock Thanks for your opinion. I've just tried to reflect it to my changes. |
|
I am happy with this as is, squashed and CHANGELOGed. |
|
I also think the code needs comments of what |
Expose Route#options
namusyaka
force-pushed
the
fix-incorrect-deprecations
branch
from
9edb8f9
to
52f60a4
Compare
|
@dblock Could you review this updates? I also squashed :) |
|
Looks good to me, feel free to merge on green if I don't get to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #1344