allow_blank for Time types #1380
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,6 +10,7 @@ | |||
| #### Fixes | |||
|
|
|||
| * [#1365](https://github.com/ruby-grape/grape/pull/1365): Fix finding exception handler in error middleware - [@ktimothy](https://github.com/ktimothy). | |||
| * #1367: `allow_blank: false` for `Time` attribute with valid value causes an error [@ipkes](https://github.com/ipkes). | |||
There was a problem hiding this comment.
Please stick to the format of other CHANGELOG entries. Pay attention to what's a link, then name, the period at the end :)
ipkes
force-pushed
the
time_allow_blank_false
branch
from
f784c97
to
bc9f393
Compare
|
I'm trying to do all according by contributing instruction. Changelog was updated, as you asked. Please correct me if I wrong. |
|
Merged via a711cab. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this
Valid value for
Timeattribute causes an error when attribute markedallow_blank: false