Allow to use regexp validator with arrays #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoltun
force-pushed
the
allow-regexp-with-arrays
branch
from
ec5b4b4
to
4021ec4
Compare
namusyaka
reviewed
Oct 6, 2016
| @@ -2,7 +2,8 @@ module Grape | |||
| module Validations | |||
| class RegexpValidator < Base | |||
| def validate_param!(attr_name, params) | |||
| return unless params.key?(attr_name) && !params[attr_name].nil? && !(params[attr_name].to_s =~ (options_key?(:value) ? @option[:value] : @option)) | |||
| return unless params.respond_to?(:has_key?) && params.has_key?(attr_name) | |||
There was a problem hiding this comment.
Rubocop said, please use key? instead of has_key.
|
@akoltun Thanks for your pull request. This change looks like reasonable. |
akoltun
force-pushed
the
allow-regexp-with-arrays
branch
from
c311f48
to
f54f9b4
Compare
|
This looks good, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ex. this will work