Replace Hashie::Mash with ActiveSupport::HashWithIndifferentAccess

[msroot]

This will replace Hashie::Mash with ActiveSupport::HashWithIndifferentAccess

[dblock]

So this is a change in API as only the top keys are with indifferent access?

[msroot]

nope! to all sub keys

[msroot]

@dblock take a look here
[params[:a]['b'][:c], params['a'][:d]]
https://github.com/msroot/grape/blob/e36710635ed905c35af51d82b72d096c99503d39/spec/grape/endpoint_spec.rb#L263-L279

[dblock]

This is similar to #1448, but better.

I think we also need to provide a backward compatible way for existing users to return a Hashie::Mash. Here's what I would like the DSL to be:

class API < Grape::API
  # params is a regular Hash
end

class API < Grape::API
   include Grape::Extensions::...::Hashie::Mash
   # params is Hashie::Mash
end

class API < Grape::API
   include Grape::Extensions::...::ActiveSupport::HashWithIndifferentAccess
   # params is HashWithIndifferentAccess
end

You get the idea ...

[msroot]

@dblock so the default should be Hash and use ActiveSupport::HashWithIndifferentAccess and Hashie::Mash as an extension?

Does the user has to explicitly require the Hashie::Mash gem then or included in grape.gemspec?

[dblock]

Yes, I think the default should be Hash.

The user should explicitly include hashie in their Gemfile in order to use the extension, and we should not have it in .gemspec anymore. For tests, it should be a development dependency.

[jdurand]

@dblock any timeline on merging this?

[dblock]

This PR won't be merged without the changes I'm asking for above.

[dblock]

Replaced with #1594.

[dblock]

Please see #1610 as a working end-to-end PR.