New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should be able to pass `nil` to an optional array values param #1559

Merged

dblock merged 3 commits into ruby-grape:master from ghiculescu:optional-nil-value

Jan 18, 2017

Contributor

ghiculescu commented Jan 18, 2017

this bug was introduced in 3540ea2#diff-45b62b4ed0aed7ceff346c347f76570e

previously, you were able to pass nil to an endpoint for an attribute that was marked as optional and had a set array of values. after the above change, this was no longer possible.

ghiculescu added 3 commits

January 18, 2017 10:06


          fix - should be able to pass nil to an optional array values param

3a6a078


          update changelog

a30d1ac


          oops

85d7ccb

coveralls commented Jan 18, 2017 •

edited

Loading

Coverage increased (+0.0005%) to 99.071% when pulling a30d1ac on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

1 similar comment

coveralls commented Jan 18, 2017 •

edited

Loading

Coverage increased (+0.0005%) to 99.071% when pulling a30d1ac on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

coveralls commented Jan 18, 2017 •

edited

Loading

Coverage increased (+0.0005%) to 99.071% when pulling 85d7ccb on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

10 similar comments

coveralls commented Jan 18, 2017

Coverage increased (+0.0005%) to 99.071% when pulling 85d7ccb on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

coveralls commented Jan 18, 2017

Coverage increased (+0.0005%) to 99.071% when pulling 85d7ccb on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

coveralls commented Jan 18, 2017

Coverage increased (+0.0005%) to 99.071% when pulling 85d7ccb on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

coveralls commented Jan 18, 2017

Coverage increased (+0.0005%) to 99.071% when pulling 85d7ccb on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

coveralls commented Jan 18, 2017

Coverage increased (+0.0005%) to 99.071% when pulling 85d7ccb on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

coveralls commented Jan 18, 2017

Coverage increased (+0.0005%) to 99.071% when pulling 85d7ccb on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

coveralls commented Jan 18, 2017

Coverage increased (+0.0005%) to 99.071% when pulling 85d7ccb on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

coveralls commented Jan 18, 2017

Coverage increased (+0.0005%) to 99.071% when pulling 85d7ccb on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

coveralls commented Jan 18, 2017

Coverage increased (+0.0005%) to 99.071% when pulling 85d7ccb on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

coveralls commented Jan 18, 2017

Coverage increased (+0.0005%) to 99.071% when pulling 85d7ccb on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

coveralls commented Jan 18, 2017 •

edited

Loading

Coverage increased (+0.0005%) to 99.071% when pulling 85d7ccb on ghiculescu:optional-nil-value into b0bc5c9 on ruby-grape:master.

dblock merged commit 3b91395 into ruby-grape:master

Member

dblock commented Jan 18, 2017

Makes sense, thanks, merged.

ghiculescu deleted the optional-nil-value branch

January 18, 2017 01:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment