Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument serialization and rendering as 'format_response.grape' #1759

Merged
merged 2 commits into from
May 5, 2018

Conversation

zvkemp
Copy link
Contributor

@zvkemp zvkemp commented May 4, 2018

A good portion of a grape API response is currently uninstrumented — when endpoint_run.grape closes, the response bodies still haven't been serialized or rendered into their appropriate templates. Adding format_response.grape instrumentation will allow us to measure time spent in this portion of the request.

@zvkemp zvkemp force-pushed the instrument-serialization branch 2 times, most recently from dc4d297 to c05ffd6 Compare May 4, 2018 17:01
@zvkemp zvkemp force-pushed the instrument-serialization branch from c05ffd6 to a87ab4a Compare May 4, 2018 19:23
@dblock
Copy link
Member

dblock commented May 4, 2018

LGTM, care to check out the build failure?

@zvkemp
Copy link
Contributor Author

zvkemp commented May 4, 2018

@dblock Failing on edge rails. Looks like it's related to the recent arel/activerecord merge.

Bundler could not find compatible versions for gem "activerecord":
  In rails_edge.gemfile:
    arel was resolved to 10.0.0.pre, which depends on
      activerecord (>= 6.a)

Unrelated to this PR, but I'd be happy to take care of it (could just tack on another commit to this one, unless you prefer to keep the issues separate).

@zvkemp zvkemp force-pushed the instrument-serialization branch 2 times, most recently from 8dc7f1c to 2633a45 Compare May 4, 2018 21:56
@zvkemp zvkemp force-pushed the instrument-serialization branch from 2633a45 to 7f9e329 Compare May 4, 2018 22:13
@dblock dblock merged commit c951628 into ruby-grape:master May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants