Add ruby 2.5 support, drop 2.2. #1813
Conversation
darren987469
force-pushed
the
update_ruby_version_in_travis
branch
from
c4a5c0c
to
2b7b7eb
Compare
darren987469
force-pushed
the
update_ruby_version_in_travis
branch
from
2b7b7eb
to
9c942f4
Compare
Generated by 🚫 danger |
darren987469
changed the title
|
👍 |
|
should https://github.com/ruby-grape/grape/blob/master/Appraisals file being updated too? |
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| source 'https://rubygems.org' | |||
|
|
|||
| gem 'rack', '1.5.2' | |||
| gem 'rack', '1.5.5' | |||
There was a problem hiding this comment.
I'm going to remove this "appraisal", as it was added specifically for fixing #1066(missing patch version in rack 1.5.2).
any objections?
moreover, now I think it does not worth it :)
| @@ -22,7 +22,7 @@ | |||
| unless RUBY_PLATFORM == 'java' | |||
| major, minor, patch = Rack.release.split('.').map(&:to_i) | |||
| patch ||= 0 # rack <= 1.5.2 does not specify patch version | |||
| pending 'Rack 1.5.3 or 1.6.1 required' unless major >= 2 || (major >= 1 && ((minor == 5 && patch >= 3) || (minor >= 6))) | |||
| pending 'Rack 1.5.5 or 1.6.1 required' unless major >= 2 || (major >= 1 && ((minor == 5 && patch >= 5) || (minor >= 6))) | |||
There was a problem hiding this comment.
this should not be changed, see #1066
There was a problem hiding this comment.
@dm1try You are right. Thanks for catching that.
Is it a proper way to remove conditional pending test and update the gem dependency?
There was a problem hiding this comment.
@darren987469 no worries, I addressed this in 87b6243
|
maybe it's a good time to drop rails 3.2 support and bump dependencies. |
1.2.0 support Ruby 2.5 ruby-grape/grape#1813 #846
1.2.0 supports Ruby 2.5 ruby-grape/grape#1813
This reverts commit 022a642. rm useless appraisal ref ruby-grape#1813, ruby-grape#1066
Summary
The new version of ruby is released. Update travis settings.
Reference: https://www.ruby-lang.org/zh_tw/