Update access to rack constant #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
dblock
reviewed
Oct 14, 2019
| @@ -213,7 +213,13 @@ def to_xml | |||
| context 'no content responses' do | |||
| let(:no_content_response) { ->(status) { [status, {}, ['']] } } | |||
|
|
|||
| Rack::Utils::STATUS_WITH_NO_ENTITY_BODY.each do |status| | |||
| STATUSES_WITHOUT_BODY = if Rack::RELEASE >= '2.1.0' | |||
There was a problem hiding this comment.
Use Gem::Version.new to compare, otherwise we're going to be in trouble with version 11.
https://medium.com/little-programming-joys/how-to-compare-version-strings-in-ruby-ced0916a4b71
There was a problem hiding this comment.
Sure, I'll fix it.
It's done in this way here: https://github.com/ruby-grape/grape/blob/master/spec/grape/integration/rack_spec.rb#L23 So I've assumed it's how you would want it here too.
There was a problem hiding this comment.
That link doesn't go anywhere interesting ;) If you see it done elsewhere, please also fix!
There was a problem hiding this comment.
It did until you've merged my other PR :)
But I'll fix this today, thank you
In rack 2.1.0 the list of statuses has become a hash with codes as keys. More info: rack/rack@6746515
|
Updated as suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix to keep up with the new changes in rack: rack/rack@6746515#diff-7c1a24d5b2fe58a6f925c7cacc6c55e7L558-R558
The format of the object with the possible statuses has changed in a recent release, which breaks the rack-edge appraisal, so this PR fixes it.