Actually mounts and curls an API #1927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's an example of a CHANGELOG.md entry: * [#1927](https://github.com/ruby-grape/grape/pull/1927): Actually mounts and curls an api - [@myxoh](https://github.com/myxoh).Generated by 🚫 danger |
|
I like it! Would make sure those command line errors are handled, I believe |
|
I've got rid of the logs. Not sure whether there was something else you were thinking about. Were you thinking about sig trapping? Signal.trap("TERM") do
shutdown()
end |
dblock
reviewed
Nov 14, 2019
| let!(:server_thread) do | ||
| Thread.new do | ||
| `fuser -k 9292/tcp 2>/dev/null` | ||
| system("rackup spec/integration/real_api/example_api/config.ru 2>/dev/null") |
There was a problem hiding this comment.
I meant that this call will fail without an exception if, for example, rackup cannot run. You need to handle the return from it.
|
Rebase/fixup? |
|
Right. I need to spend some time getting this right, but it's been a very busy month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a way of doing and end-end test of grape with a sample API and actually performing API calls against it.
I am open to suggestions.
Tests the issue described in: #1901