Address some Ruby warnings #1995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nbeyer
commented
Feb 19, 2020
nbeyer
commented
- Add warnings enablement to spec_helper.rb to see future warnings
- Use instance_variable_defined? to clean up not initialized warnings
- Add 'inherited' to NON_OVERRIDABLE list
- Add multi_xml to test dependencies in Gemfile to address spec failure
dblock
approved these changes
Feb 21, 2020
* Add warnings enablement to spec_helper.rb to see future warnings * Use instance_variable_defined? to clean up not initialized warnings * Add 'inherited' to NON_OVERRIDABLE list * Add multi_xml to test dependencies in Gemfile to address spec failure
|
@dblock This PR has been rebased. |
dblock
requested changes
Feb 24, 2020
|
Merged, thank you. |
|
Now that we run with |
|
I've not found anything great for failing tests based on unexpected warnings. It's possible to plug into Ruby's Warning module, but it would require some framework building, as it seems likely that warnings from dependencies are going to pop-up, which would be out of the control of this project. |
basjanssen
pushed a commit
to basjanssen/grape
that referenced
this pull request
Feb 28, 2020
* Address some Ruby warnings * Add warnings enablement to spec_helper.rb to see future warnings * Use instance_variable_defined? to clean up not initialized warnings * Add 'inherited' to NON_OVERRIDABLE list * Add multi_xml to test dependencies in Gemfile to address spec failure * Add changelog entry * expand changelog entry * adjust changelog * remove unnecessary multi_xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.