Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade coerce behavior when rescuing error. #2006

Merged
merged 2 commits into from
Mar 6, 2020

Conversation

ericproulx
Copy link
Contributor

Fix Style/RescueStandardError

As discussed @dblock

@grape-bot
Copy link

grape-bot commented Mar 5, 2020

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

@ericproulx
Copy link
Contributor Author

ericproulx commented Mar 5, 2020

After reading this article, when rescue has no argument, its actually rescuing StandardError implicitly.

Based on rubocop doc, default is explicit so that's why it appeared in the todo.

Fix Style/RescueStandardError
@dblock
Copy link
Member

dblock commented Mar 5, 2020

Oh, my bad. Made you do the work for nothing. Rebase and merge.

@dblock dblock merged commit 960c7a7 into ruby-grape:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants