Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop retained regexes #2011

Merged
merged 1 commit into from
Mar 15, 2020
Merged

Conversation

ericproulx
Copy link
Contributor

I removed the code that retain regexes in Route and Any classes since its union.

# Based on our app
# 1.3.1
Total allocated: 41885240 bytes (308172 objects)
Total retained:  6000260 bytes (11806 objects)

#next version
Total allocated: 41851936 bytes (305115 objects)
Total retained:  3419455 bytes (8907 objects)

Almost half total retained :)

@grape-bot
Copy link

grape-bot commented Mar 15, 2020

1 Warning
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.

Generated by 🚫 danger

…need to keep the regexes in memory.

Add CHANGELOG.md
@@ -2,7 +2,7 @@

#### Features

* Your contribution here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually keep those.

@dblock dblock merged commit 600eee9 into ruby-grape:master Mar 15, 2020
@dblock
Copy link
Member

dblock commented Mar 15, 2020

I encourage you to write a blog post somewhere about the optimizations in Grape! If you don't have a venue I would be happy to host on code.dblock.org.

@ericproulx
Copy link
Contributor Author

I encourage you to write a blog post somewhere about the optimizations in Grape! If you don't have a venue I would be happy to host on code.dblock.org.

Thanks that would be great. I'll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants