Fix a regression in coerce_with when coercion returns nil #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misdoro
force-pushed
the
coerce_with_regression
branch
from
16f494e
to
fbd4e9d
Compare
…ns nil Previously nil was handled as valid value for coercion for integer parameters. With refactoring introduced in 1.3.0 integer parameter coerced with a custom method can't coerce to nil any more. This change reverts back to previous behavior where coercion to nil was allowed.
misdoro
force-pushed
the
coerce_with_regression
branch
from
fbd4e9d
to
af45dff
Compare
dblock
reviewed
Mar 20, 2020
dblock
reviewed
Mar 20, 2020
misdoro
force-pushed
the
coerce_with_regression
branch
from
219608a
to
adb2672
Compare
|
I think I would want a sanity check from @dnesteryuk for this PR. If this is not a regression but a breaking change that was introduced by design, it may well just make sense to update the |
|
I err on the side of caution and would update UPGRADING anyway. @dnesteryuk all yours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously nil was handled as valid value for coercion for integer parameters.
With refactoring introduced in 1.3.0 integer parameter coerced with a custom method can't coerce to nil any more.
This change reverts back to previous behaviour where coercion to nil was allowed.