Ensure floats are correctly coerced to bigdecimal #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlconnor
force-pushed
the
fixBigDecimalCoercion
branch
from
527ed52
to
b3616b2
Compare
dblock
requested changes
Mar 31, 2020
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ | |||
| #### Fixes | |||
|
|
|||
| * Your contribution here. | |||
| * [#2033](https://github.com/ruby-grape/grape/pull/2033): Ensure floats are correctly coerced to bigdecimal - [@tlconnor](https://github.com/tlconnor). | |||
There was a problem hiding this comment.
quote and spell Float and BigDecimal
tlconnor
force-pushed
the
fixBigDecimalCoercion
branch
from
b3616b2
to
4a52bea
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for
Floatcoercion toBigDecimal#2032.When checking for equality of params, checks both the class and value of params rather than just the value.
/cc: @dblock @dnesteryuk