Fix eager loading due to ServeStream rename #2072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can add a(n integration) spec for this, can't we? Calling |
|
Bump @stanhu want to finish this? |
stanhu
force-pushed
the
sh-fix-eager-loading-servefile
branch
2 times, most recently
from
a9f1236
to
0dd6ccc
Compare
|
@dblock Ok, done. |
dblock
reviewed
Jun 25, 2020
Closed
stanhu
force-pushed
the
sh-fix-eager-loading-servefile
branch
from
0dd6ccc
to
fcafe0d
Compare
dblock
requested changes
Jun 25, 2020
|
Errr... now looking into this I have more questions.
|
|
This issue also happens after calling: API.compile!So, we might use it in the integration test. |
|
@stanhu Want to finish so we can include this in the release? Let's include |
stanhu
force-pushed
the
sh-fix-eager-loading-servefile
branch
from
fcafe0d
to
bdc1dd9
Compare
|
@dblock I'm not sure if this is what you wanted, but take a look. |
ServeFile was renamed to ServeStream in ruby-grape#1520. Calling Grape.eager_load! would fail with: ``` uninitialized constant Grape::ServeFile (NameError) ```
stanhu
force-pushed
the
sh-fix-eager-loading-servefile
branch
from
bdc1dd9
to
09e3156
Compare
|
Made some changes and merged via b3adbb4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServeFile was renamed to ServeStream in #1520. Calling Grape.eager_load!
would fail with: