Set Cache-Control only for streamed responses #2088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanhu
commented
Jul 11, 2020
stanhu
force-pushed
the
sh-fix-issue-2087
branch
from
b56f707
to
019595e
Compare
dblock
reviewed
Jul 13, 2020
stanhu
force-pushed
the
sh-fix-issue-2087
branch
2 times, most recently
from
907fbee
to
946e641
Compare
The pull request ruby-grape#1520 introduced a regression that always caused the `Cache-Control` HTTP header to be set to `no-cache`, even if the response wasn't a stream. To fix this, we only set HTTP headers if there is an actual stream. Closes ruby-grape#2087
stanhu
force-pushed
the
sh-fix-issue-2087
branch
from
946e641
to
28dde32
Compare
Merged
2 tasks
jsugarman
added a commit
to ministryofjustice/Claim-for-Crown-Court-Defence
that referenced
this pull request
Oct 9, 2020
version 1.4 broke Cache-Control that we rely on see ruby-grape/grape#2088 Full [Change log](https://github.com/ruby-grape/grape/blob/master/CHANGELOG.md)
jsugarman
added a commit
to ministryofjustice/Claim-for-Crown-Court-Defence
that referenced
this pull request
Oct 12, 2020
version 1.4 broke Cache-Control that we rely on see ruby-grape/grape#2088 Full [Change log](https://github.com/ruby-grape/grape/blob/master/CHANGELOG.md)
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request #1520 introduced a regression that always caused the
Cache-ControlHTTP header to be set tono-cache, even if theresponse wasn't a stream. To fix this, we only set HTTP headers if there
is an actual stream.
Closes #2087