fix a performance issue with dependent params #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnesteryuk
force-pushed
the
resolve_performace_issue_with_given
branch
from
d0d4d11
to
1e6555f
Compare
Generated by 🚫 danger |
dblock
approved these changes
Oct 27, 2020
UPGRADING.md
Outdated
| #### Dependent params | ||
|
|
||
| If you use [dependent params](https://github.com/ruby-grape/grape#dependent-parameters) with | ||
| `Grape::Extensions::Hash::ParamBuilder`, make sure a parameter to be dependent on is set as a Symbol |
There was a problem hiding this comment.
Explain what won't work? In this case a String? Also add a period at the end of the sentence or maybe a before/after section?
There was a problem hiding this comment.
Also add a period at the end of the sentence or maybe a before/after section?
I am not sure what you mean here 😊 Could you explain?
There was a problem hiding this comment.
a Symbol. (it's a full sentence, just missing a period)
There was a problem hiding this comment.
Regarding before/after, you're saying make sure it's a Symbol. What happens if it's not? Explain that.
dnesteryuk
force-pushed
the
resolve_performace_issue_with_given
branch
2 times, most recently
from
3f52bb7
to
ffcb7dd
Compare
Fixes #2100 The reason was in `ActiveSupport::HashWithIndifferentAccess`, it is super expensive. When users use a `Grape::Extensions::ActiveSupport::HashWithIndifferentAccess::ParamBuilder` or `Grape::Extensions::Hashie::Mash::ParamBuilder` parameter builder there is no change. However, users who use `Grape::Extensions::Hash::ParamBuilder` must make sure a parameter to be dependent on must be a symbol. given :matrix do # block here end Benchmark after this fix: Warming up -------------------------------------- Given 1.000 i/100ms Simple 1.000 i/100ms Calculating ------------------------------------- Given 0.804 (± 0.0%) i/s - 49.000 in 61.186831s Simple 0.855 (± 0.0%) i/s - 52.000 in 60.926097s Comparison: Simple: 0.9 i/s Given: 0.8 i/s - 1.06x slower
dnesteryuk
force-pushed
the
resolve_performace_issue_with_given
branch
from
ffcb7dd
to
affd474
Compare
|
@dblock please, have a look again. thanks. |
dblock
reviewed
Oct 28, 2020
|
|
||
| If you use [dependent params](https://github.com/ruby-grape/grape#dependent-parameters) with | ||
| `Grape::Extensions::Hash::ParamBuilder`, make sure a parameter to be dependent on is set as a Symbol. | ||
| If a String is given, a parameter that other parameters depend on won't be found even if it is present. |
There was a problem hiding this comment.
So is this a bug? Should we also fix this (in another PR)?
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2100
The reason was in
ActiveSupport::HashWithIndifferentAccess, it is super expensive.When users use a
Grape::Extensions::ActiveSupport::HashWithIndifferentAccess::ParamBuilderorGrape::Extensions::Hashie::Mash::ParamBuilderparameter builder there is no change. However, users who useGrape::Extensions::Hash::ParamBuildermust make sure a parameter to be dependent on must be a symbol.Benchmark after this fix: