Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoload Types #2209

Merged
merged 8 commits into from Dec 28, 2021
Merged

Autoload Types #2209

merged 8 commits into from Dec 28, 2021

Conversation

ericproulx
Copy link
Contributor

Hello

This PR is Like #2207 but for Types

Thanks

Moved build_coercer in types.rb
@grape-bot
Copy link

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@dblock
Copy link
Member

dblock commented Dec 27, 2021

Would you please check the CI failures on those optional rubies? I think the jruby one is caused by #2207

@ericproulx
Copy link
Contributor Author

@dblock I've installed JRuby-9.3.2.0 locally and everything works fine. Current JRuby build is failing. It might be related.

@dblock
Copy link
Member

dblock commented Dec 27, 2021

I opened https://github.com/dry-rb/dry-container/issues/81 to track the dry-types/dry-container problem.

@dblock dblock merged commit 224402f into ruby-grape:master Dec 28, 2021
dm1try added a commit to dm1try/grape that referenced this pull request Dec 30, 2021
ericproulx added a commit to ericproulx/grape that referenced this pull request Jan 3, 2022
ericproulx pushed a commit to ericproulx/grape that referenced this pull request Jan 3, 2022
@ericproulx ericproulx mentioned this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants