Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly require bigdecimal and date. #2263

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Explicitly require bigdecimal and date. #2263

merged 1 commit into from
Jun 14, 2022

Conversation

dblock
Copy link
Member

@dblock dblock commented Jun 13, 2022

Closes #2260.

@grape-bot
Copy link

grape-bot commented Jun 13, 2022 •
edited

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@dblock dblock mentioned this pull request Jun 13, 2022
Closed
@dblock dblock merged commit 4d46a6f into ruby-grape:master Jun 14, 2022
@dblock dblock deleted the bigdecimal branch June 14, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some tests fail with uninitialized constant Grape::Validations::Types::BigDecimal
2 participants
@dblock @grape-bot