Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An unexpected backtick #2284

Merged
merged 2 commits into from
Oct 21, 2022
Merged

An unexpected backtick #2284

merged 2 commits into from
Oct 21, 2022

Conversation

zysend
Copy link
Contributor

@zysend zysend commented Oct 20, 2022

found an unexpected backtick while learning

@dblock
Copy link
Member

dblock commented Oct 20, 2022 •
edited
Loading

Weird that somehow made it into the codebase!

Spec will need to be updated too and CHANGELOG.

  1) Grape::API.rescue_from klass, with: :method_name aborts if the specified method name does not exist
     Failure/Error: expect { get '/rescue_method' }.to raise_error(NoMethodError, /^undefined method `not_exist_method'/)

@zysend
Copy link
Contributor Author

zysend commented Oct 20, 2022

Weird it seems that there are double backticks.
Thanks for the reminder.

@dblock dblock merged commit 62562f8 into ruby-grape:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zysend @dblock