Revisit GitHub workflows #2301
Merged
Revisit GitHub workflows #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor ruby-matrix on test and edge Add rubygems: latest Add 3.2
Add rubygems in danger.yml
Exclude [Rails 7.0, Ruby 2.6]
dblock
reviewed
Jan 2, 2023
.github/workflows/test.yml
Outdated
| runs-on: ubuntu-20.04 | ||
| os: [ubuntu-latest] | ||
| ruby: ['2.6', '2.7', '3.0', '3.1', '3.2'] | ||
| gemfile: [multi_json, multi_xml, rack_1_0, rack_2_0, rack_2_2, rails_5_2, rails_6_0, rails_6_1, rails_7_0] |
There was a problem hiding this comment.
This becomes a massive matrix and the list of exclude will grow.
We could make something like https://github.com/slack-ruby/slack-ruby-client/blob/master/.github/workflows/test.yml#L13 potentially to make it easier to grok, WDYT?
There was a problem hiding this comment.
I've reduced it and add some specific inclusion.
Lock rack_3_0 to not include 3.1 Remove rack_2_2 in favor of 2_0 to test Rename rack3 to rack_3_0 Testing workflow include/exclude
testing gemfile rack_2_0, rails_6_0, rails_6_1, rails_7_0 include 2.6 for rails_5_2 include 2.7 for rack_1_0, multi_json, multi_xml
Remove matrix os in edge Add rubygems: latest to rubocop
dblock
approved these changes
Jan 9, 2023
|
It's a step in the right direction thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates current GH workflows.
Overall changes:
Specific changes