Feature: Allows procs with arity 1 to validate and use custom messages #2333
Conversation
- now allows a proc to validate and use custom messages - adds @proc_message instance variable - creates the skip_validation? method to pass rubocops cyclomatic error
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| #### Features | |||
|
|
|||
| * [#2333] (https://github.com/ruby-grape/grape/pull/2333): The `validate_param!` now allows procs to validate and use custom messages [@thedevjoao](https://github.com/TheDevJoao). | |||
There was a problem hiding this comment.
I think "Use custom messages in parameter validation." may be clearer?
There was a problem hiding this comment.
I don't see
:proc_messageanywhere in specs, how is this wired up?! I must be missing something obvious sweat_smile
Hey @dblock , thanks for the review! Your comment helped out a ton, turns out what I was doing wasn't necessary. I recently refactored the code to cover what was suggested here and it should make more sense as an added feature. 😃
TheDevJoao
changed the title
| when 1 | ||
| param_array.all? { |param| proc.call(param) } | ||
| else | ||
| raise ArgumentError, 'proc arity must be 0 or 1' |
There was a problem hiding this comment.
Do we get some kind of useful call stack with a line number such as that the developer knows where the error comes from?
There was a problem hiding this comment.
Yeah, considering the ruby and rails versions that grape supports, the stack trace will show every sequence leading to this raise statement.
|
@TheDevJoao add a test for when arity is > 1 and we can merge? |
@dblock Done! 🤝 |
This PR resolves #2280
As this is my first contribution to the repo, I am open to any form of feedback!
PS: I also created the tests with the example shown in the issue in mind.