Fix custom validator not ending with _validator #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
dblock
reviewed
Jun 10, 2023
|
|
||
| RSpec.describe Grape::Validations::Validators::Base do | ||
| describe '#inherited' do | ||
| # I tried with `Class.new(Grape::Validations::Validators::Base) but `inherited` is not called. |
There was a problem hiding this comment.
Does https://avdi.codes/classnew-and-inherited/ help?
dblock
approved these changes
Jun 10, 2023
CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ | |||
| #### Fixes | |||
|
|
|||
| * [#2328](https://github.com/ruby-grape/grape/pull/2328): Don't cache Class.instance_methods - [@byroot](https://github.com/byroot). | |||
| * [#2337](https://github.com/ruby-grape/grape/pull/2337): Fix custom validator registering - [@ericproulx](https://github.com/ericproulx). | |||
There was a problem hiding this comment.
Let's say "Fix: allow custom validators that do not end with _validator"?
Hmmmm... this clearly isn't right. |
Update spec comment Add spec for anonymous class
|
Thanks for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2336