Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Grape::Deprecator's Behavior in test #2402

Merged

Conversation

ericproulx
Copy link
Contributor

This PR will set Grape::Deprecator's Behavior to raise when running specs. Our spec suite should not pass through our own deprecations unless its expected.

@grape-bot
Copy link

grape-bot commented Jan 3, 2024

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

Revert docker-compose.yml
@ericproulx ericproulx marked this pull request as ready for review January 3, 2024 22:45
@ericproulx ericproulx changed the title Set Grape::Deprecator's Behavior set to raise in test Change Grape::Deprecator's Behavior in test Jan 3, 2024
@dblock dblock merged commit 3d85058 into ruby-grape:master Jan 4, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants