Replace Appraisals by eval_gemfile #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update test gems including rubocop Regenerate Rubocop's todo
Generated by 🚫 Danger |
dblock
approved these changes
Apr 16, 2024
dblock
requested changes
Apr 16, 2024
Fix rubocop Add CHANGELOG
dblock
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
I spot-checked that we end up with Rack 2.0 for the rack_2.0.gemfile. I think we should add tests in the rack and rails integrations that ensure that the version matches the intended one, e.g.
expect(Gem::Version.new(Rack.release).segments.first).to eq 2Up to you if you want to do this as part of this/future PR/maybe I can get to it, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops Appraisals in favor of eval_gemfile. It also updates some gems like rubocop, rack-test etc ...
I don't know if we need instructions if someone wants to add a new Gemfile but looking at the current ones might give a very good idea of the how to.