Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nodejs16 within coverallsapp/github-action #2436

Merged
merged 4 commits into from
May 4, 2024
Merged

Fix nodejs16 within coverallsapp/github-action #2436

merged 4 commits into from
May 4, 2024

Conversation

ericproulx
Copy link
Contributor

@ericproulx ericproulx commented May 4, 2024 •
edited
Loading

I noticed these warnings when running test workflow.

coverallsapp/github-action changed master to main.

@ericproulx ericproulx requested a review from dblock May 4, 2024 17:23
dblock
dblock reviewed May 4, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a released version of these? The @main reference is a moving target.

@ericproulx
Copy link
Contributor Author

Is there a released version of these? The @main reference is a moving target.

There's a V2. I'll try that

@ericproulx
Copy link
Contributor Author

@dblock it works :)

@ericproulx ericproulx requested a review from dblock May 4, 2024 19:03
@dblock dblock merged commit 5cc85c3 into ruby-grape:master May 4, 2024
44 checks passed
@dblock
Copy link
Member

dblock commented May 4, 2024

Thanks @ericproulx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock Awaiting requested review from dblock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericproulx @dblock