Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove builder as a dependency #2445

Merged
merged 3 commits into from
May 21, 2024
Merged

Remove builder as a dependency #2445

merged 3 commits into from
May 21, 2024

Conversation

ericproulx
Copy link
Contributor

Fix #2443

@ericproulx
Remove builder as a dependency
ee9a404 
Add UPGRADING.md entry
@ericproulx ericproulx marked this pull request as ready for review May 20, 2024 18:48
@grape-bot
Copy link

grape-bot commented May 20, 2024 •
edited

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 Danger

dblock
dblock reviewed May 20, 2024
View reviewed changes
UPGRADING.md Outdated
@@ -3,6 +3,10 @@ Upgrading Grape

### Upgrading to >= 2.1.0

#### Builder => XML

From now on, if you want to generate XML, you'll need to add `builder` in your Gemfile.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some details. Maybe this.

The `builder` gem dependency has been made optional as it's only used when generating XML. If your code does XYZ, add `builder` to `Gemfile`. 

See [#2445](https://github.com/ruby-grape/grape/pull/2445) for more information.

dblock
dblock requested changes May 20, 2024
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README also needs an update around XML to say builder needs to be added in certain circumstances.

Also, no tests failed?

@ericproulx
Copy link
Contributor Author

ericproulx commented May 21, 2024 •
edited

The README also needs an update around XML to say builder needs to be added in certain circumstances.

Also, no tests failed?

It's in the our test Gemfile

@dblock dblock merged commit 848e97a into ruby-grape:master May 21, 2024
44 checks passed
@dblock
Copy link
Member

dblock commented May 21, 2024 •
edited

The README also needs an update around XML to say builder needs to be added in certain circumstances.
Also, no tests failed?

It's in the our test Gemfile

Does it make sense to remove it from there and move XML tests to integration? Probably does, can be done in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dropping builder as dependency ?
3 participants
@ericproulx @grape-bot @dblock