Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default response headers to work with Rack 3 #2455

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

ericproulx
Copy link
Contributor

Fix #2452

…patibility

Add gcompat for nokogiri in Dockerfile. Needed for testing a Rails app
Add tzinfo-data in Rails's Gemfiles. Needed for testing a Rails app
Add integration test rails thats mounts a Grape API within a Rails App
Move railtie_spec.rb to rails integration
@ericproulx ericproulx marked this pull request as ready for review June 20, 2024 21:00
@grape-bot
Copy link

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@ericproulx ericproulx requested a review from dblock June 20, 2024 22:08
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@dblock dblock merged commit b1123d8 into ruby-grape:master Jun 20, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Routing priority issue in Grape v2.1.0 when using with rails
3 participants