Only catch formatter errors in formatter middleware

[kbarrette]

Should fix #359

[tucker250]

+1

[dblock]

This definitely needs a spec to be merged, please.

[kbarrette]

@dblock definitely - added specs.

[dblock]

Sorry, forgot to ask you to please update CHANGELOG as well. Sorry to be a pest.

[kbarrette]

Done.

[kbarrette]

@dblock Any update on this?

[dblock]

It's still on my todo list to merge. I wanted to add a spec to see what happens when the formatter raises some other exception and there's a rescue for :all. It should properly get caught and all that. Since this is a problem in my head I didn't want to ask you to add it, but that would definitely save me the time :)

[kbarrette]

I'm happy to help, but I'm not sure I understand what you're proposing. My second example 'does not rescue other exceptions' should test the case where the formatter raises an exception that is not Grape::Exceptions::InvalidFormatter. I'm not sure where the rescue :all would be, since my thought here is that Grape should explicitly NOT rescue other exceptions.

[dblock]

Yes, yes, your spec is correct. I mean adding another spec that makes sure that if I do a rescue_from :all, then I catch any other exception from the formatter. Otherwise anything that goes wrong in the formatter cannot be rescued and so there's no way for a Rack API with Grape to return a 500 for example with a stack trace on "all other errors".

[kbarrette]

Ah, I understand now! I'll add a spec shortly.

[kbarrette]

Done.

[dblock]

@kbarrette Perfect, merging.