API version overriding version parameter

[tmornini]

Hello there fine fellows!

Beginning to use and love Grape, but have run into a serious issue which I am unable to resolve myself.

I have an endpoint described as such:

params do
  optional :description, :type => String,  :desc => 'Book description'
  optional :reference,   :type => String,  :desc => 'Book reference'
  requires :version,     :type => Integer, :desc => 'Book current version'
end

This works fine with API versioning via headers when I pass in this body:

{"description":"Updated Description","reference":"b:a","version":2}

However, when I use API versioning via path, the version parameter is set to the API version from the path, which results in a 403 with this body:

{"error":"invalid parameter: version"}

I verified this at coerce.rb by adding these lines after line 14:

puts attr_name
puts params[attr_name]

This produces:

version
pacioli

where pacioli is my API version from:

class App < ::Grape::API
  version 'pacioli', :using => :path

I believe this to be 100% incorrect. :-)

Let me know if I can help in any way!

P.S. The 403 is weird in itself as line 15 of coerce.rb certainly appears to throw a 400.

[tmornini]

Hacked on this all day and came up with this fix.

Thanks for Grape, I really appreciate it!

[tmornini]

Hold on this, though specs are green, this issue does not appear to be entirely fixed...

[tmornini]

Strike that! Reverse it... (said in a Gene Wilder as Willy Wonka voice)

This is ready to go, issue was header-related on my side. :-)

[tmornini]

Newer and simpler, and no longer breaks(!) grape-swagger :-)

[dblock]

Thanks! Can you please update CHANGELOG, too?

[dblock]

There're a ton of whitespace additions. I am sure you feel that it looks better, but would you mind cleaning up those, the implicit coding style is less sparse in Grape :) Nothing person, just want to minimize change.

[dblock]

This can be written more concisely as version = versions.join('|') if versions.

[tmornini]

@dblock Thanks the input, I'd be more than happy to make the changes you've suggested!

[dblock]

Thanks, looking forward to an update.

[tmornini]

OK, how's that?

[dblock]

I committed a fix for this in c065f33, using your code, but without all the other unrelated changes. Let me know if I missed anything. Thx.