goliath passes request header keys as symbols #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please write a test for this and update CHANGELOG. Thank you. |
|
Ping @bobek. I want this, but I also want it with a test / changelog update. Want to do it? |
|
Hi @dblock , can you please check the new commit? I didn't find any less hackinsh way how to modify env before hitting the Endpoint in the test. |
|
Totally clean in my world, merging. |
dblock
added a commit
that referenced
this pull request
Jun 2, 2013
goliath passes request header keys as symbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
goliath passes key in headers hash as symbols. This trivial patch fixes the undefined start_with for symbol error otherwise causing crash of the app.
Antonin