Adding POST style parameters for DELETE request. #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll take it. Can you please also update CHANGELOG? |
|
There you go. |
dblock
added a commit
that referenced
this pull request
Jul 30, 2013
Adding POST style parameters for DELETE request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Grape used to accept POST style parameters for DELETE request. So I'm adding it back here.
However, I know that the HTTP spec doesn't explicitly disallow request bodies (where POST parameters go) for DELETE requests and many server implementations ignore it and you may run into issues with proxies dropping the content. So I'll leave it to you to decide if you which too add it.
References:
http://www.quora.com/Is-there-any-way-to-pass-parameters-for-HTTP-DELETE-method
http://stackoverflow.com/questions/299628/is-an-entity-body-allowed-for-an-http-delete-request