allow :type parameter on group param keyword - closes #605 #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,6 +36,7 @@ Next Release | |||
| * [#557](https://github.com/intridea/grape/pull/557): Pass `content_types` option to `Grape::Middleware::Error` to fix the content-type header for custom formats. - [@bernd](https://github.com/bernd). | |||
| * [#585](https://github.com/intridea/grape/pull/585): Fix after boot thread-safety issue - [@etehtsea](https://github.com/etehtsea). | |||
| * [#587](https://github.com/intridea/grape/pull/587): Fix oauth2 middleware compatibility with [draft-ietf-oauth-v2-31](http://tools.ietf.org/html/draft-ietf-oauth-v2-31) spec - [@etehtsea](https://github.com/etehtsea). | |||
| * [#605](https://github.com/intridea/grape/issues/605): Fixed group keyword was not working with type parameter - [@klausmeyer](https://github.com/klausmeyer/). | |||
There was a problem hiding this comment.
In CHANGELOG we add a link to this PR, not to a closed issue
[#605](https://github.com/intridea/grape/issues/605) to [#610](https://github.com/intridea/grape/pull/610)
There was a problem hiding this comment.
Ok, changed now. Sorry about that.
|
looks good for me 👌 |
|
Thanks! |
dblock
added a commit
that referenced
this pull request
Mar 29, 2014
allow :type parameter on group param keyword - closes #605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test and fix for #605