endpoint#present makes needless sql query #632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So who defines |
|
Yes, it's standard method of ActiveRecord relations, it returns the relation's model and it's very useful in case of |
| @@ -13,6 +13,7 @@ Next Release | |||
| * [#614](https://github.com/intridea/grape/pull/614): Params with `nil` value are now refused by `RegexpValidator` - [@dm1try](https://github.com/dm1try). | |||
| * [#494](https://github.com/intridea/grape/issues/494): Fixed performance issue with requests carrying a large payload - [@dblock](https://github.com/dblock). | |||
| * [#619](https://github.com/intridea/grape/pull/619): Convert specs to RSpec 3 syntax with Transpec - [@danielspector](https://github.com/danielspector). | |||
| * [#632](https://github.com/intridea/grape/pull/632): Usage of Grape::Endpoint#present for ActiveRecord relations doesn't make an additional query during entity's detection | |||
There was a problem hiding this comment.
@fixme , please mention yourself :)
... during entity's detection - [@fixme](https://github.com/fixme).
|
Merged via 597fabf, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, here is some fix to prevent needless sql query in endpoint#present method, because of #first method usage on activerecord relations.
Example:
it makes an additional sql query on
booksrelation because of #first method usage in entity's auto-detection block.