Allow passing options hash to a custom validator #719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow passing options hash to a custom validator
elado
changed the title
elado
changed the title
|
This looks legit. Can you please update CHANGELOG and fix the Rubocop errors? See the Travis build failure. Thx. |
|
@dblock Done! |
|
Merged via 706e841. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed options check on Validator (was unnecessary + wrong syntax)
Allowed passing options hash to a custom validator
Original Code referred
Grape::Exceptions.UnknownOptionswhich not valid (should've beenGrape::Exceptions::UnknownOptions).Fixes #718