Fix Grape::Middleware::Base#response #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks legit, I guess this isn't used by anyone? Maybe we should delete it? This needs a spec, please and a CHANGELOG entry. |
Galathius
force-pushed
the
fix-rack-response-initialize
branch
3 times, most recently
from
a59700d
to
31385a3
Compare
|
👍 |
| @@ -1,7 +1,7 @@ | |||
| Next Release | |||
| ============ | |||
|
|
|||
| * Your contribution here. | |||
Galathius
force-pushed
the
fix-rack-response-initialize
branch
from
31385a3
to
116001e
Compare
| @@ -2,6 +2,7 @@ Next Release | |||
| ============ | |||
|
|
|||
| * Your contribution here. | |||
| * [#871](https://github.com/intridea/grape/pull/871): Fixed Rack::Response initialize - [@galathius](https://github.com/galathius). | |||
There was a problem hiding this comment.
I am still nitpicking, what is fixed is the Grape::Middleware::Base#response method, not Rack::Response#initialize, so this should say Fixed Grape::Middleware::Base#response - .... Also swap with the above line, future contributions will go below this one usually.
Galathius
changed the title
Galathius
force-pushed
the
fix-rack-response-initialize
branch
from
116001e
to
c371fa9
Compare
|
Last thing, the description in the commit itself is wrong, same issue as with what was in the CHANGELOG. Thanks for hanging in there, I am a picky code-reviewer. |
| @@ -2,6 +2,7 @@ Next Release | |||
| ============ | |||
|
|
|||
| * Your contribution here. | |||
| * [#871](https://github.com/intridea/grape/pull/871): Fixed Grape::Middleware::Base#response - [@galathius](https://github.com/galathius). | |||
There was a problem hiding this comment.
Oh and I still want you to swap the order of this line with "Your contribution here.", so that's below.
Galathius
force-pushed
the
fix-rack-response-initialize
branch
from
c371fa9
to
42d8a18
Compare
|
+1 |
Galathius
force-pushed
the
fix-rack-response-initialize
branch
from
42d8a18
to
05cfc5e
Compare
|
Thanks, merging. |
dblock
added a commit
that referenced
this pull request
Dec 30, 2014
Fix Grape::Middleware::Base#response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.