Fix 'uninitialized constant Net::LDAP::PDU::LdapPduError' error

ruby-ldap · Feb 14, 2019 · 3ef1c6e · 3ef1c6e
1 parent 9daa954
commit 3ef1c6e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/net/ldap/pdu.rb b/lib/net/ldap/pdu.rb
@@ -123,7 +123,7 @@ def initialize(ber_object)
     when ExtendedResponse
       parse_extended_response(ber_object[1])
     else
-      raise LdapPduError.new("unknown pdu-type: #{@app_tag}")
+      raise Net::LDAP::PDU::Error, "unknown pdu-type: #{@app_tag}"
     end
 
     parse_controls(ber_object[2]) if ber_object[2]

diff --git a/test/test_ldap_connection.rb b/test/test_ldap_connection.rb
@@ -340,6 +340,19 @@ def test_queued_read_bind_sasl
     assert result.success?
     assert_equal 2, result.message_id
   end
+
+  def test_invalid_pdu_type
+    options = {
+      app_tag: Net::LDAP::PDU::SearchResult,
+      code: Net::LDAP::ResultCodeSuccess,
+      matched_dn: "",
+      error_message: "",
+    }
+    ber = Net::BER::BerIdentifiedArray.new([options[:code], options[:matched_dn], options[:error_message]])
+    assert_raise Net::LDAP::PDU::Error do
+      Net::LDAP::PDU.new([0, ber])
+    end
+  end
 end
 
 class TestLDAPConnectionErrors < Test::Unit::TestCase