Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for undefined method for write exception #383

Merged
merged 1 commit into from
Nov 30, 2020
Merged

fix for undefined method for write exception #383

merged 1 commit into from
Nov 30, 2020

Conversation

gupta-kanika-dev
Copy link

Opening the PR for issue: #382

  • Method#socket returns @conn sometimes as nil because it is only checking that it is defined or not. (a defined @conn can be nil when it is dead in between)
  • checking that along with its definition it should not be nil too.

Date: Mon Nov 23 16:27:38 2020 +0530
Committer: Kanika Gupta railsstarter@github.com

fix for undefined method for write exception
b1eec43 
 Date:      Mon Nov 23 16:27:38 2020 +0530
 Committer: Kanika Gupta <railsstarter@github.com>
@sukeerthiadiga
Copy link

+1

HarlemSquirrel
HarlemSquirrel approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@HarlemSquirrel HarlemSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thank you!

@HarlemSquirrel HarlemSquirrel merged commit a37cc08 into ruby-ldap:master Nov 30, 2020
@HarlemSquirrel HarlemSquirrel mentioned this pull request Nov 30, 2020
Closed
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarlemSquirrel HarlemSquirrel HarlemSquirrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gupta-kanika-dev @sukeerthiadiga @HarlemSquirrel